Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLX503: post-experiment tweaks #7168

Closed
3 tasks done
rerpha opened this issue May 23, 2022 · 4 comments
Closed
3 tasks done

HLX503: post-experiment tweaks #7168

rerpha opened this issue May 23, 2022 · 4 comments
Assignees

Comments

@rerpha
Copy link
Contributor

rerpha commented May 23, 2022

As an instrument scientist using the ITC powered 3he fridge for the first time (this was on WISH) I would like some changes to be made.

Acceptance Criteria

What is the acceptance criteria?
Following issues are fixed:

  • It would be better if the threshold for switching between the HE3POTLO and HE3POTHI thermometers was separate to the threshold used for switching between high and low temperature mode. I think we discussed this when we implemented the thermometer switching, but ended up using the same threshold for speed. Unfortunately this didn’t work out during real usage.
  • There are a lot of communications drop outs for some reason which causes the reported temperature to drop down to zero. See attached.
  • The switching the heater off every time a new setpoint is sent is messing up the PIDs, causing very noticeable temperature drops and hence time delays each time the setpoint is changed (again, see graph).

Extra Information

Why it is needed?

Where required files/links are

How to Test

verbose instructions for reviewer to test changes
(Add before making a PR)

@rerpha
Copy link
Contributor Author

rerpha commented May 23, 2022

@rerpha rerpha added this to the Sprint_2022_05_19 milestone May 23, 2022
@rerpha rerpha self-assigned this May 23, 2022
@rerpha
Copy link
Contributor Author

rerpha commented May 23, 2022

We are going to test on the real sorb tomorrow afternoon so will make changes if needed.

@rerpha rerpha added the 5 label May 23, 2022
@rerpha
Copy link
Contributor Author

rerpha commented May 26, 2022

branches patched over to WISH, seems to be working fine and ran overnight with some tests which looked OK according to instrument scientists. Still some issues with a first recondense being temperamental but not introduced by this ticket. To review check db files look OK. IOC tests don't exist on master just yet as I need to sort them out as part of #6240

@rerpha
Copy link
Contributor Author

rerpha commented May 26, 2022

PS drop outs were caused by incorrect default stop bit setting which was different to the ITC503 - have modified to match the ITC and that has solved the comms issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants