Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MuSR: 3He Refrigerator Testing #6243

Closed
3 tasks
JamesKingWork opened this issue Feb 16, 2021 · 12 comments
Closed
3 tasks

MuSR: 3He Refrigerator Testing #6243

JamesKingWork opened this issue Feb 16, 2021 · 12 comments
Assignees
Labels
5 no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@JamesKingWork
Copy link
Contributor

JamesKingWork commented Feb 16, 2021

As a MuSR scientist, I would like the 3He Refrigerator IOC to be sufficiently tested against hardware.

Acceptance criteria:

  • Test plan and outcomes are documented in this ticket
  • Communications to the device is tested against hardware
  • Control logic of the IOC is tested against hardware

Notes:

  • The 3He refrigerator is a Heliox/ITC503 based system
  • LabVIEW VIs are at C:\LabVIEW Modules\Oxford Software\Muon Heliox

3He Refrigerator tickets:

@JamesKingWork
Copy link
Contributor Author

They do want to use this for the upcoming cycle and cryogenics have confirmed that they can set up the machine shortly after the software is completed

@KathrynBaker KathrynBaker added the 5 label Mar 4, 2021
@kjwoodsISIS kjwoodsISIS added this to the SPRINT_2021_03_04 milestone Mar 4, 2021
@JamesKingWork
Copy link
Contributor Author

Impeded waiting on #6294 and #6240. We could do an initial test after the communications are reworked and then test the autocondense separately

@JamesKingWork
Copy link
Contributor Author

The testing for this device is currently being postponed to enable EMU mercury itc and MUSR soak testing

@JamesKingWork
Copy link
Contributor Author

The current plan is to move back to SECI if this device is needed in the next cycle. Removing it from the board and impeded, will propose again when MUSR want to test

@JamesKingWork JamesKingWork removed this from the SPRINT_2021_04_01 milestone Apr 7, 2021
@rerpha
Copy link
Contributor

rerpha commented May 16, 2022

@rerpha rerpha added this to the Sprint_2022_04_21 milestone May 16, 2022
@rerpha
Copy link
Contributor

rerpha commented May 18, 2022

we may need to use #7143 if possible as the state machine seems to be sending commands in sequence too quickly!

@rerpha
Copy link
Contributor

rerpha commented May 19, 2022

OK, there was a race condition that was causing things to happen in no given order when setting a SP (though mostly just the sorb SP) which was caused by DLYs in sseq that called other sseq records with the same delay, ie

sseq1
 - set this pv
 - delay 0.1 seconds
 - do sseq2 
 - delay 0.1 seconds 
 - set another pv    <---- this might happen before sseq2 finishes as the delay is the same inbetween sseq

sseq2
- set this pv
- delay 0.1 seconds 
- etc

I have bodged this for now by setting the outer delay to be longer (0.5) than the inner delays (0.1 each) added up in total, and this seems to work quite nicely. I don't want to change this without another opportunity to test with hardware but we should probably do something like use a WAITn instead - though this might not wait for the nested sequence to finish which would be something else to test.

@rerpha
Copy link
Contributor

rerpha commented May 19, 2022

im going to be a bit cheeky and merge the above branches into master so we can have a built copy in case my copied-over version does not work in the morning. hopefully the build completes!

@rerpha
Copy link
Contributor

rerpha commented May 20, 2022

in a nutshell, everything seemed to work and we managed a recondense as well as skipping through the first part of a recondense. setting setpoints for sorb/he3 pot now work well. I will be setting up on WISH today so will put this in review once they are happy

@rerpha rerpha added 13 and removed 5 labels May 23, 2022
@rerpha
Copy link
Contributor

rerpha commented May 23, 2022

repointing - some other things are needed:

  • It would be better if the threshold for switching between the HE3POTLO and HE3POTHI thermometers was separate to the threshold used for switching between high and low temperature mode. I think we discussed this when we implemented the thermometer switching, but ended up using the same threshold for speed. Unfortunately this didn’t work out during real usage.
  • There are a lot of communications drop outs for some reason which causes the reported temperature to drop down to zero.
  • The switching the heater off every time a new setpoint is sent is messing up the PIDs, causing very noticeable temperature drops and hence time delays each time the setpoint is changed (again, see graph).

@rerpha
Copy link
Contributor

rerpha commented May 23, 2022

actually, i will create a new ticket for this, as the hardware testing has now happened and the other things can be considered separate tasks.

Reviewing this one won't really require much reviewing as WISH used the sorb but would like some tweaks made. I might just close it, but feel free to open it again and review if you disagree

@rerpha rerpha added 5 and removed 13 labels May 23, 2022
@rerpha
Copy link
Contributor

rerpha commented May 23, 2022

#7168 is the tweaks ticket

@rerpha rerpha closed this as completed May 23, 2022
@rerpha rerpha added the no_release_notes Tickets that do not need release notes, use sparingly! label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Development

No branches or pull requests

5 participants