Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add containerfile #43

Merged
merged 4 commits into from
Sep 23, 2024
Merged

add containerfile #43

merged 4 commits into from
Sep 23, 2024

Conversation

rerpha
Copy link
Contributor

@rerpha rerpha commented Sep 20, 2024 •
edited
Loading

closes #21

Tom-Willemsen
Tom-Willemsen approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this as a first pass (was able to get it up and running locally pretty easily with this approach).

Could we add some options for configuring where to find PVWS? Happy for you to do this as a separate ticket if you want...

@rerpha rerpha merged commit 08374be into main Sep 23, 2024
3 checks passed
@rerpha rerpha deleted the dockerfile branch October 1, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Willemsen Tom-Willemsen Tom-Willemsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

containerise
2 participants
@rerpha @Tom-Willemsen