Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instruments page #61

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Improve instruments page #61

merged 3 commits into from
Nov 8, 2024

Conversation

Tom-Willemsen
Copy link
Contributor

@rerpha any thoughts (draft atm)? I think this is a bit better than what we currently have, but could probably go a bit further with some bits...

@Tom-Willemsen
Copy link
Contributor Author

Was half thinking to make the border colour of each instrument correspond to their runstate but that's probably way overkill...

@rerpha
Copy link
Contributor

rerpha commented Nov 7, 2024

looks good i'd add maybe a gap between each box. Dark mode also looks a bit strange so may need to use dark: border-white or something around the boxes. - think my browser was being stupid, it looks good to me.

if you wanted colours to runstate we already do that in the wall display, so shouldn't be too bad to do - it even uses the instlist currently so could make the page look very similar but split up by science group

@Tom-Willemsen Tom-Willemsen marked this pull request as ready for review November 8, 2024 06:41
@rerpha rerpha merged commit a1bd621 into main Nov 8, 2024
3 checks passed
@rerpha rerpha mentioned this pull request Nov 8, 2024
1 task
@rerpha rerpha deleted the improve_inst_page branch November 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants