show runstate on instruments page #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the runstate to the instruments page by using the same mechanism as the wall display rather than rewriting all the instlist-handling for each page.
the main changes are that i've moved the logic for subscribing to the instlist and runstate pvs then parsing them to a component in
app/components/InstrumentsDisplay.tsxand then used that for both, but with a different "sorting" method.This PR also adds a load of snapshot tests to each of the groups so we can easily track when things break - ideally we'd also have unit tests for these as, despite saying we've got a much higher coverage number, we aren't really testing logic thinly.