-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket6244 - Adding OPI for 3he fridge system #1266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
John-Holt-Tessella
previously requested changes
Mar 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You need a PV_ROOT set
- Background should be grey not white; if you want the diagram to be white put the white behind the diagram
- All labels should be in sentence case with colons
- Can you run OPI checks (non-strict) and check all errors, e.g. graph error
- Check parent macros has ITC and HELIOX in
- Put a bit of space between the graph and the box so they don't overlap
- Graph heart beats are on heliox not HLX
- Why is there a script on the opi that doesn't seem to do anything
- Are we expecting animation on the picture as valves close and open?
… spacing, adding pv root from HLX
… where appropriate and add setting of PIDs and PID files
JamesKingWork
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Adds a device screen for the 3he fridge system on musr.
Ticket
ISISComputingGroup/IBEX#6244
Acceptance criteria
See ticket
Unit tests
None
System tests
None
Documentation
Highlight and provide a link to any additions or changes to the documentation, if applicable. The aim is provide information to help the reviewer
Code Review
Final Steps