Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename default_args to current_args #216

Merged
merged 1 commit into from
Dec 19, 2024
Merged

rename default_args to current_args #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions installation_and_upgrade/IBEX_upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import re
import sys

import ibex_install_utils.default_args
import ibex_install_utils.current_args
import semantic_version # pyright: ignore
from ibex_install_utils.exceptions import ErrorInTask, UserStop
from ibex_install_utils.file_utils import FileUtils
Expand Down Expand Up @@ -110,7 +110,7 @@ def _get_latest_existing_dir_path(release_dir: str, component: str) -> str:
parser.add_argument("--kits_icp_dir", default=None, help="Directory of kits/ICP")
parser.add_argument(
"--server_arch",
default=ibex_install_utils.default_args.SERVER_ARCH,
default=ibex_install_utils.current_args.SERVER_ARCH,
choices=["x64", "x86"],
help="Server build architecture.",
)
Expand All @@ -126,7 +126,7 @@ def _get_latest_existing_dir_path(release_dir: str, component: str) -> str:

args = parser.parse_args()

ibex_install_utils.default_args.SERVER_ARCH = args.server_arch
ibex_install_utils.current_args.SERVER_ARCH = args.server_arch

if not args.no_log_to_var:
Logger.set_up()
Expand Down
2 changes: 1 addition & 1 deletion ...pgrade/ibex_install_utils/default_args.py → ...pgrade/ibex_install_utils/current_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
SERVER_ARCH = "x64"
SERVER_ARCH = "x64"
4 changes: 2 additions & 2 deletions installation_and_upgrade/ibex_install_utils/tasks/system_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,9 @@ def install_or_upgrade_vc_redist(self) -> None:
"""
Install the latest visual studio redistributable files
"""
import ibex_install_utils.default_args
import ibex_install_utils.current_args

arch = ibex_install_utils.default_args.SERVER_ARCH
arch = ibex_install_utils.current_args.SERVER_ARCH

print(f"Installing vc_redist for arch: {arch}")

Expand Down
Loading