Ticket3492 update upgrade script #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2019
| @@ -43,6 +45,9 @@ | |||
| SOURCE_MACHINE_SETTINGS_CONFIG_PATH = os.path.join(SOURCE_FOLDER, SETTINGS_CONFIG_FOLDER, "NDXOTHER") | |||
| SOURCE_MACHINE_SETTINGS_COMMON_PATH = os.path.join(SOURCE_FOLDER, SETTINGS_CONFIG_FOLDER, "common") | |||
|
|
|||
| THIRD_PARTY_INSTALLERS_REL_DIR = "..\\..\\third_party_installers" | |||
| """ | ||
| Reminds the user to copy the third party installs from the share | ||
| """ | ||
| print("This is a new feature. If you find problems, add them to #3492, or open a new one and reference #3492") |
There was a problem hiding this comment.
I don't think this line is needed (if bugs are found, we'll find the appropriate ticket anyway)
| for installer in installers: | ||
| if "Git" in installer: | ||
| RunProcess(working_dir=THIRD_PARTY_LATEST, executable_file=installer, prog_args=GIT_INSTALL_ARGS).run() | ||
| # TODO update git config |
There was a problem hiding this comment.
Surely this is just a call to git_configs() which you've defined below?
There was a problem hiding this comment.
Yep, I forgot to remove the TODO comment
…it being re-installed half way through it's session
|
There is a problem with re-installing git from within python - gitpython doesn't like the executable changing under it. I attempted to fix it in the latest commit but there is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated script to:
It also no longer asks the user to update web dashboard