Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #289

Merged
merged 18 commits into from
Jan 30, 2024
Merged

Code cleanup #289

merged 18 commits into from
Jan 30, 2024

Conversation

MBartkowiakSTFC
Copy link
Collaborator

Description of work
Mainly removing unnecessary fragments of code.

Fixes

  • deleted the old GUI code (wxWidgets part),
  • deleted the SVG file format,
  • deleted ComplexNumber and the matching configurator,
  • moved the GUI code from MDANSE_GUI/PyQtGUI to MDANSE_GUI

To test
If the deleted code was correctly identified as unused, there should be no change to the way MDANSE works.
Unit tests should all pass.

Copy link
Collaborator

@ChiCheng45 ChiCheng45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all unittest pass on my end and GUI loads up without issues.

@MBartkowiakSTFC MBartkowiakSTFC merged commit 8d295f5 into protos Jan 30, 2024
54 checks passed
@MBartkowiakSTFC MBartkowiakSTFC deleted the code-cleanup branch January 30, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants