Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifest file for generating source distribution #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robertapplin
Copy link
Collaborator

@robertapplin robertapplin commented Apr 5, 2024

Description
This PR is preparation for creating a conda recipe for quickBayes.

We need the source distribution uploaded to PyPi to contain all source files including the test directory.

To test

  1. Run the following from the root of this repo
python setup.py sdist
  1. Open the tarball created in the dist/ folder
  2. Check that the test directory is included as well as the src directory

The source distribution (i.e. tarball), which contains the test directory, needs to then be uploaded to PyPi for quickBayes.

@robertapplin robertapplin force-pushed the 0-create-manifest-file branch from 23e7b8b to 33eb80a Compare April 5, 2024 09:07
@AnthonyLim23
Copy link
Collaborator

@robertapplin I am holding off on reviewing this due to #89

I think the fix is to remove the setup.py and replace it with a pyproject.toml

Creating and uploading to PyPi is handled by the release workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants