Av 1076 fix monte python #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthshrotri
commented
Nov 3, 2023
…ation seems to not work
rbhog
requested changes
Nov 12, 2023
| enable_direction_variance=atmo_args.get("enable_direction_variance", False), | ||
| enable_magnitude_variance=atmo_args.get("enable_magnitude_variance", False), | ||
| nominal_wind_magnitude=atmo_args.get("nominal_wind_magnitude", 0.0), | ||
| nominal_wind_direction=atmo_args.get("nominal_wind_direction", np.array([0, 0, 0]))) |
There was a problem hiding this comment.
probably better for the sake of standardization and legibility to have each of these fields explicitly defined in the dictionary before being passed in
|
|
||
| # Indices of each state variable in the output array | ||
| # kf and rkf values are arrays containing position, velocity and acceleration in each axis | ||
| indices = {"time":0, |
There was a problem hiding this comment.
better as an enum, see enum package
There was a problem hiding this comment.
also looking back, probably better to just have a global dataframe or smth to hold sim data because then we can access fields by property name and it's alr sorted by timestamps
| "kalman_raccel_z":60} | ||
|
|
||
| default_output_folder = 'Output' | ||
| def rmse(predictions, targets): |
| "launch_angle_stddev": 0.00} | ||
|
|
||
| monte(dt, kf_dt, samples, output_folder, target_size, **sim_params) |
| "launch_angle_stddev": 0.00} | ||
|
|
||
| monte(dt, kf_dt, samples, output_folder, target_size, **sim_params) |
There was a problem hiding this comment.
idk if out of scope but idt this code is thread safe so if we wanna ramp up number of runs in parallel we need to do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructured code into Configurations, Simulation core, executables, and output.
Cleaned up executing files.
Pysim can now be called by monte-python for Monte Carlo analysis
Monte-python now outputs to csv files