Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Перенёс задания А и Б в свои функции, добавил тесты программы при запуске main функции #152
base: Chadov_Sergej_Vadimovich
Are you sure you want to change the base?
Перенёс задания А и Б в свои функции, добавил тесты программы при запуске main функции #152
Changes from 18 commits
cd08682
4339ac5
d78dc16
b6c0e76
19b4f2f
379dbb0
58c9e06
024edad
08048ae
c03f80c
1343c2d
af70f57
877752e
38f0853
efa2b1d
18abfc8
1a7e4aa
b52c100
2997edc
8a3b48b
dd3fcea
71aa1a6
babd06e
52aa7f4
2384469
6806f27
1b07799
6a32963
7a6bf05
527741c
fdb6a1f
5748713
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔕 используйте словарь
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CamelCase
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Принято - все ок
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я б ее тоже сделал public (Formula) чтобы ее можно было проверить в тестах ну и логично что ее потенциально могут переисполоьзовать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Перенести в параметр функции
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не оставляйте закомментированный код
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добавьте отдельные тесты на формулу
В этих тестах проверьте возможные значения передаваемые в формулу, особенно критические
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тест должен падать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В задаче а проверяем что возвращается срез ожидаемого размера
1 - нормальное вычисление
2 xk > xn (0 значений)
3 dx > xk-xn (1 значение)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - дассив длины >0
2 - пустой массив
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Немного не понял, тест должен проверять какой длинны входной массив? Или выходной массив?
И какой смысл проверять на пустоту массива, если первым уже проверили, что его длина больше нуля?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выходной