Prokudina lab 9 #511
Open
Prokudina lab 9 #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hristinaprokudina
changed the base branch from
master
to
Prokudina_Khristina
FeLL1kS
reviewed
Dec 23, 2024
golang/lab9/lab9.go
Outdated
Comment on lines
12
to
29
| type Task struct { | ||
| Description string `json:"description"` | ||
| Completed bool `json:"completed"` | ||
| } | ||
|
|
||
| type TaskManager struct { | ||
| Tasks []Task | ||
| } | ||
|
|
||
| type TaskManagerInterface interface { | ||
| AddTask(description string) | ||
| ShowTasks() | ||
| CompleteTask(index int) | ||
| DeleteTask(index int) | ||
| SearchTask(keyword string) | ||
| SaveToFile(filename string) | ||
| LoadFromFile(filename string) | ||
| } |
There was a problem hiding this comment.
Разделяйте все на разные файлы. Всегда
FeLL1kS
reviewed
Dec 23, 2024
golang/lab9/lab9.go
Outdated
| @@ -0,0 +1,170 @@ | |||
| package lab9 | |||
There was a problem hiding this comment.
Где-то я эту реализацию видел, копипаст? Еще и коммит один, подозрительно
There was a problem hiding this comment.
Ответ то будет тут?) Сможете защитить лабораторную эту на паре или снизим балл?
There was a problem hiding this comment.
Здравствуйте, что не так с коммитом?
FeLL1kS
reviewed
Dec 25, 2024
golang/lab9/task_manager.go
Outdated
| @@ -0,0 +1,104 @@ | |||
| package lab9 | |||
There was a problem hiding this comment.
Название файла тоже должно быть CamelCase
|
Так же не увидел использование лабы в main.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.