feat: math func lab + codewars #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeLL1kS
reviewed
Oct 10, 2024
rpgsaga/saga/src/index.ts
Outdated
| @@ -1 +1,34 @@ | |||
| console.log('Hello world'); | |||
There was a problem hiding this comment.
Создай отдельный файл под эту лабу, в индексе либо храни экспорты, либо удали
rpgsaga/saga/src/index.ts
Outdated
| console.log(`Ответы к задаче A: ${taskA(xStart, xEnd, xStep)}`); | ||
| console.log(`Ответы к задаче B: ${taskB(listX)}`); | ||
|
|
||
| export function death(x: number) { |
rpgsaga/saga/src/index.ts
Outdated
| return res; | ||
| } | ||
|
|
||
| export function taskA(xStarts: number, xEnds: number, xSteps: number) { |
rpgsaga/saga/src/index.ts
Outdated
| return listOfRes; | ||
| } | ||
|
|
||
| export function taskB(listsX: Array<number>) { |
There was a problem hiding this comment.
Вместо Array<number> просто используй number[]. Возвращаемый тип
rpgsaga/saga/src/index.ts
Outdated
| } | ||
|
|
||
| export function taskB(listsX: Array<number>) { | ||
| const listOfRes = []; |
rpgsaga/saga/src/index.ts
Outdated
| } | ||
|
|
||
| export function taskA(xStarts: number, xEnds: number, xSteps: number) { | ||
| const listOfRes = []; |
rpgsaga/saga/src/index.ts
Outdated
| console.log(`Ответы к задаче B: ${taskB(listX)}`); | ||
|
|
||
| export function death(x: number) { | ||
| const res = (Math.pow(Math.sin(x), 3) + Math.pow(Math.cos(x), 3)) * Math.log(x); |
There was a problem hiding this comment.
можно сократить, добавив return сразу сюда
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.