RPG Saga #10
Open
RPG Saga #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskonst
requested changes
Nov 6, 2022
Comment on lines
+1
to
+9
| <<<<<<< HEAD | ||
| BinaryTree/bin/ | ||
| BinaryTree/net6.0/ | ||
| BinaryTree/obj/ | ||
|
|
||
| RpgSaga/bin/ | ||
| RpgSaga/net6.0/ | ||
| RpgSaga/obj/ | ||
| ======= |
There was a problem hiding this comment.
плохая идея с конфликтами заливать
| @@ -0,0 +1,68 @@ | |||
| namespace BinaryTree | |||
There was a problem hiding this comment.
только давайте все же в подкаталог с CourseApp - или stylecop нфдо настравивать
| @@ -0,0 +1,28 @@ | |||
| | |||
There was a problem hiding this comment.
аналогично - или в 1 каталог с CourseApp или надо настроить gh actions и stylecop
| { | ||
| public abstract class Ability | ||
| { | ||
| protected bool DoBlindActions(Player player, Player enemy) |
There was a problem hiding this comment.
а почему ability знает про 2 игроков?
| { | ||
| public Archer(int health, int strength, string name, Ability ability) : base(health, strength, name, ability) | ||
| { | ||
| PlayerClass = "Лучник"; |
There was a problem hiding this comment.
тут хорошо бы enum текстовый использовать
jskonst
requested changes
Nov 6, 2022
Comment on lines
+21
to
+28
| _playerLogger.EnterTheNumberOfPlayers(); | ||
| if (int.TryParse(Console.ReadLine(), out int number)) | ||
| { | ||
| if (number % 2 == 0 && number > 0) | ||
| { | ||
| return number; | ||
| } | ||
| } |
There was a problem hiding this comment.
пользовательский ввод в отдельном классе стоит обрабатывать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.