Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recovery password #62

Merged
merged 15 commits into from
Sep 17, 2023
Merged

Feature/recovery password #62

merged 15 commits into from
Sep 17, 2023

Conversation

CynthiaPM
Copy link
Collaborator

The created components include a ForgetController for handling password recovery functionality. It uses ForgetRequest and ResetRequest request classes for validating email and new password inputs. An email template (reset_password.blade.php) is created for sending password reset links to users. These components are integrated with routes to initiate the forget password process, validate the reset request, and update the password.

@CloudSalander
Copy link
Collaborator

Hi, Cynthia!
Some comments:

  • Please, don't put extra blank lines on the code. They make the number of lines increase with no justification. If found too much of this on the ForgetController.php.
  • About the controller, maybe could be a good idea to put this logic on the UserController cause its part of the resource user.
  • Thanks for the Request Validator!
  • Veery nice email template :)
  • Please, no capital letters on API endpoins. Separate word with hyphenate.
  • We should discuss with our product owner(Luis) about specifical details on the password recovering dialog.
  • Despite all of this, its evident that you did a good job. Let's wait for some boss discussions to decide if we merge or we improve this feature.

Thanks!

@CloudSalander
Copy link
Collaborator

Hei, Cynthia!
Please, solve conflicts and add Swagger support to your endpoints.
Thanks!

@CloudSalander
Copy link
Collaborator

Thanks for all the changes, Cynthia.
I'd like to comment some details tomorrow about the recovering flux before merging this branch.
A couple of details more:

  • Please, don't put endpoint names with uppercase.
  • There is a little english mistake with the error message of the forgetpassword token. "The email does not exist

Thanks!

@CloudSalander CloudSalander merged commit bc6d50e into develop Sep 17, 2023
@CloudSalander
Copy link
Collaborator

Closed but pending to solve server sending and link to React page for sending new password.

@FranEnLaNube FranEnLaNube linked an issue Nov 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] Recover password
2 participants