Feature/calling GitHub api #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also the swagger is update
|
Hi, Cynthia! Good job. Some comments:
Need some time to still checking the feature, but If you can check this firsts issues. Thanks! |
|
Testing the endpoint manually as the Swagger explains, didn't work for me :( |
…specific project, updated swagger
|
Thank you, Cynthia! Good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I have implemented the API call to GitHub for the various repositories of the project using the owner's token. The main component responsible for handling this functionality is the CollaboratorsController, which contains the necessary logic. The retrieved data is filtered to include only the collaborator's name, photo, and GitHub URL.
The implementation adheres to Swagger documentation standards, providing clear guidelines for API consumption. To ensure a streamlined and organized approach, a single URL is used to access the required information.
The implemented functionality has been thoroughly tested, and all tests are passing successfully. This ensures the reliability and functionality of the API endpoints.
---UPDATE---
I have made some modifications to the code regarding collaborators. Now, a single API call will return all the collaborators without any duplicates, as we had several collaborators appearing in more than two projects.
In order to reflect these changes, I have updated the Swagger documentation accordingly. Now, it accurately represents the updated behavior of the API.
Additionally, I have tested the modifications, and I can confirm that all the tests are functioning as expected after the changes were made.