Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AUTOSCALING_LOGLEVEL #429

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 added the t:enhancement New feature or request label Nov 13, 2023
@mrnicegyu11 mrnicegyu11 added this to the 7peaks milestone Nov 13, 2023
@mrnicegyu11 mrnicegyu11 self-assigned this Nov 13, 2023
@YuryHrytsuk
Copy link
Collaborator

Is it the right place? Not in osparc-simcore?

@mrnicegyu11
Copy link
Member Author

Is it the right place? Not in osparc-simcore?

@YuryHrytsuk that could be, you are the expert so you tell me:

In osparc-simcore we already have:

  autoscaling:
    image: ${DOCKER_REGISTRY:-itisfoundation}/autoscaling:${DOCKER_IMAGE_TAG:-latest}
    init: true
    hostname: "{{.Node.Hostname}}-{{.Service.Name}}-{{.Task.Slot}}"
    networks:
      - autoscaling_subnet
    environment:
      - LOG_LEVEL=${LOG_LEVEL:-WARNING}

so it captures the "global" LOG_LEVEL, but i want to be able to set the AUTOSCALER's loglevel specifically to DEBUG for ... debugging. What is the proper way to do this? :)

@sanderegg
Copy link
Member

Is it the right place? Not in osparc-simcore?

@YuryHrytsuk that could be, you are the expert so you tell me:

In osparc-simcore we already have:

  autoscaling:
    image: ${DOCKER_REGISTRY:-itisfoundation}/autoscaling:${DOCKER_IMAGE_TAG:-latest}
    init: true
    hostname: "{{.Node.Hostname}}-{{.Service.Name}}-{{.Task.Slot}}"
    networks:
      - autoscaling_subnet
    environment:
      - LOG_LEVEL=${LOG_LEVEL:-WARNING}

so it captures the "global" LOG_LEVEL, but i want to be able to set the AUTOSCALER's loglevel specifically to DEBUG for ... debugging. What is the proper way to do this? :)

Actually @mrnicegyu11 @YuryHrytsuk we should find a way to set a LOG_LEVEL to separate services. because, even using AUTOSCALING_LOG_LEVEL, how will set a different log level for different instances of Autoscaling. For example in the case where we would have one for s4l-lite and another for sim4life ?

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment still hold I guess ;)

@mrnicegyu11
Copy link
Member Author

my comment still hold I guess ;)

Yes, but I have no clue how yet :/

@sanderegg
Copy link
Member

@mrnicegyu11 I think you can disable that PR. I will replace it completely and autoscaling_log_level will come in directly in osparc-simcore.
Also I will issue a PR where the autoscaling here gets simpler (as are the other services.)
for info see -> ITISFoundation/osparc-simcore#5033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants