-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Graylog cannot parse log_timestamp #430
Merged
YuryHrytsuk
merged 20 commits into
ITISFoundation:main
from
YuryHrytsuk:fix-graylog-issue
Nov 13, 2023
Merged
BUGFIX: Graylog cannot parse log_timestamp #430
YuryHrytsuk
merged 20 commits into
ITISFoundation:main
from
YuryHrytsuk:fix-graylog-issue
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! this one was nasty :)
mrnicegyu11
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes the bug described in #426. In short,
simcore
services logs andtraefik
logs contain timestamp of different format which leads to occasional failure to parse any simcore service logs.Solution
By stopping capturing timestamps generated by
traefik
, we make sure that alllog_timestamp
values have the same formatRelated PR
For history and future usage
There are multiple solutions to this problem. We can create custom index mapping and tell explicitly
ES
which type should havelog_timestamp
but there is no easy solution to accessES API
sinceES
is not reachable from the outside.Other solution is to introduce
space is used as a separator which
T
separator in alllog_timestamps
generated bysimcore
services (currentlyES date
type do no understand by default).