Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Graylog cannot parse log_timestamp #430

Merged
merged 20 commits into from
Nov 13, 2023

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Nov 13, 2023

Problem

This PR fixes the bug described in #426. In short, simcore services logs and traefik logs contain timestamp of different format which leads to occasional failure to parse any simcore service logs.

Solution

By stopping capturing timestamps generated by traefik, we make sure that all log_timestamp values have the same format

Related PR

For history and future usage

There are multiple solutions to this problem. We can create custom index mapping and tell explicitly ES which type should have log_timestamp but there is no easy solution to access ES API since ES is not reachable from the outside.

Other solution is to introduce T separator in all log_timestamps generated by simcore services (currently space is used as a separator which ES date type do no understand by default).

@YuryHrytsuk YuryHrytsuk self-assigned this Nov 13, 2023
@YuryHrytsuk YuryHrytsuk added the t:bug Something isn't working label Nov 13, 2023
@YuryHrytsuk YuryHrytsuk added this to the 7peaks milestone Nov 13, 2023
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this one was nasty :)

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX

@YuryHrytsuk YuryHrytsuk merged commit 72fead5 into ITISFoundation:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants