Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: validate simcore stack yml bash script - to be used in CI/CD #441

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Add: validate simcore stack yml bash script - to be used in CI/CD #441

merged 7 commits into from
Nov 17, 2023

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Nov 15, 2023 •
edited
Loading

This uses the simcore-settings library to validate that the pydantic checks of all simcore microservices passes with the env-vars baked into a simcore_stack.yml file.

The following docker services that are part of the simcore-stack are bypassed:

  • director (no settings library)
  • migration (no settings library)
  • postgres (3rd party)
  • rabbit (3rd party)
  • redis (3rd party)
  • traefik (3rd party)
  • traefik_api (3rd party)
  • whoami (3rd party)

This goes with https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/149

Bonus: Renamed some venv folder to .venv

@mrnicegyu11 mrnicegyu11 added this to the 7peaks milestone Nov 15, 2023
@mrnicegyu11 mrnicegyu11 self-assigned this Nov 15, 2023
@mrnicegyu11 mrnicegyu11 added the t:enhancement New feature or request label Nov 15, 2023
pcrespov
pcrespov approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! thx

scripts/deployments/validate_simcore_stack_yml.bash Show resolved Hide resolved
sanderegg
sanderegg approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice addition

This was referenced Nov 17, 2023
Open
Closed
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review November 17, 2023 08:33
@mrnicegyu11 mrnicegyu11 merged commit bc81258 into ITISFoundation:main Nov 17, 2023
3 checks passed
@YuryHrytsuk
Copy link
Collaborator

gut gemacht! Kudos 🎉

@mrnicegyu11 mrnicegyu11 mentioned this pull request Nov 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@mrnicegyu11 mrnicegyu11

Labels
t:enhancement New feature or request
Projects
None yet
Milestone
7peaks
Development

Successfully merging this pull request may close these issues.
4 participants
@mrnicegyu11 @YuryHrytsuk @pcrespov @sanderegg