Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appmotion gw: switch traefik routes #495

Merged

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jan 5, 2024

What do these changes do?

Expose appmotion gateway route

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk added this to the Kobayashi Maru milestone Jan 5, 2024
@YuryHrytsuk YuryHrytsuk requested a review from pcrespov January 5, 2024 15:59
@YuryHrytsuk YuryHrytsuk self-assigned this Jan 5, 2024
@YuryHrytsuk YuryHrytsuk changed the title Appmotion gw switch traefik routes Appmotion gw: switch traefik routes Jan 5, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed avoid this to be propagated to staging for at least a week

scripts/common.Makefile Show resolved Hide resolved
services/appmotion_gateway/docker-compose.yml Show resolved Hide resolved
services/appmotion_gateway/docker-compose.yml Show resolved Hide resolved
@mrnicegyu11
Copy link
Member

Please remind me to review again before merging once you and @pcrespov have settled on the current disussions :)

@YuryHrytsuk
Copy link
Collaborator Author

Please remind me to review again before merging once you and @pcrespov have settled on the current disussions :)

Sure thing. We can sit and discuss together 👍

@YuryHrytsuk YuryHrytsuk requested a review from pcrespov January 8, 2024 08:25
@YuryHrytsuk YuryHrytsuk merged commit 32315b5 into ITISFoundation:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants