Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ k8s: Introduce Namespaces + Cleanups #836

Merged
merged 11 commits into from
Oct 17, 2024
Merged

♻️ k8s: Introduce Namespaces + Cleanups #836

merged 11 commits into from
Oct 17, 2024

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Oct 15, 2024 •
edited
Loading

What do these changes do?

  • Adds more makefile help comments
  • Adds helmfile-sync makefile target
  • Adds potential extra points to README.md
  • Adds (purely for conveniance) k8s makefile targets up & leave
  • Adds reflector to copy secrets between makefiles automatically
  • Changes: Use env-var K8S_MONITORING_FQDN in favor of k8s.monitoring.{{ requiredEnv "MACHINE_FQDN" }}

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@mrnicegyu11 mrnicegyu11 changed the title 2024/add/k8s/portainer Add: Portainer on kubernetes Oct 15, 2024
@mrnicegyu11 mrnicegyu11 changed the title Add: Portainer on kubernetes ♻️ k8s: Introduce Namespaces + Cleanups Oct 15, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Oct 15, 2024
@mrnicegyu11 mrnicegyu11 added this to the MartinKippenberger milestone Oct 15, 2024
@mrnicegyu11 mrnicegyu11 added the t:enhancement New feature or request label Oct 15, 2024
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review October 15, 2024 09:10
YuryHrytsuk
YuryHrytsuk reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 Namespace concepts looks good and promising

I added a few comments. Let's discuss

charts/Makefile Show resolved Hide resolved
charts/Makefile Show resolved Hide resolved
charts/Makefile Show resolved Hide resolved
charts/traefik/values.insecure.yaml.gotmpl Outdated Show resolved Hide resolved
charts/traefik/values.webinternal.yaml.gotmpl Outdated Show resolved Hide resolved
charts/cert-manager/values.selfsigned.yaml.gotmpl Outdated Show resolved Hide resolved
charts/traefik/values.insecure.yaml.gotmpl Outdated Show resolved Hide resolved
charts/traefik/values.insecure.yaml.gotmpl Outdated Show resolved Hide resolved
charts/Makefile Outdated Show resolved Hide resolved
@mrnicegyu11
Copy link
Member Author

@YuryHrytsuk please re-review thx

YuryHrytsuk
YuryHrytsuk approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's get it rolling

@mrnicegyu11 mrnicegyu11 merged commit d0a911f into ITISFoundation:main Oct 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

Assignees

@mrnicegyu11 mrnicegyu11

Labels
t:enhancement New feature or request
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnicegyu11 @YuryHrytsuk