Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor stack #850

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Oct 21, 2024

What do these changes do?

  • Add vendor stack
  • Introduce authenticated_platform_user middleware

Implementation insights

  • In case AUTH Server is down, the routers using authenticated_platform_user middleware in this case will return 500
  • The middleware authenticated_platform_user is available as long as OPS Traefik is up and running
  • Vendor's manual service is only available via public network

Related issue/s

Related PR/s

Checklist

  • I tested and it works
  • The Stack has been included in CI Workflow
  • Service has resource limits and reservations
  • Service has placement constraints or is global
  • Service is restartable
    • The restart is zero-downtime
  • Service can migrate to another Node without manual intervention
  • Add e2e ops test for manual #853

@YuryHrytsuk YuryHrytsuk added this to the MartinKippenberger milestone Oct 21, 2024
@YuryHrytsuk YuryHrytsuk self-assigned this Oct 21, 2024
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review October 22, 2024 13:28
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We need to discuss how and who is pushing the images to private dockerhub

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, does this need changes in osparc-config?

edit: nevermind just saw the link :--)

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@YuryHrytsuk YuryHrytsuk merged commit 2d690e0 into ITISFoundation:main Oct 23, 2024
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the add-vendor-stack branch October 23, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "manual" service to a new stack called "vendors"
4 participants