Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendors stack: support multiple domains & maintenance mode #886

Merged
merged 4 commits into from
Nov 21, 2024
Merged

vendors stack: support multiple domains & maintenance mode #886

merged 4 commits into from
Nov 21, 2024

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Nov 20, 2024 •
edited
Loading

What do these changes do?

  • add multiple-domains support for vendors manual
  • include vendors manual in maintenance
  • add j2cli customization support

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@YuryHrytsuk YuryHrytsuk self-assigned this Nov 20, 2024
@YuryHrytsuk YuryHrytsuk added this to the Event Horizon milestone Nov 21, 2024
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review November 21, 2024 08:54
mrnicegyu11
mrnicegyu11 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find with the customization, fits good with our architecture. We could use this in more places actually. Didnt know this existed, thanks a lot

:--)

services/vendors/j2cli_customization.py Show resolved Hide resolved
services/vendors/docker-compose.yml.j2 Show resolved Hide resolved
@YuryHrytsuk YuryHrytsuk merged commit c0e11cd into ITISFoundation:main Nov 21, 2024
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the add-manual-to-maintenance branch November 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
p:high-prio
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Vendors manual: support multiple domains and maintenance mode
2 participants
@YuryHrytsuk @mrnicegyu11