Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dy-static-file-server will consider initial input state as to be synced #159

Merged
merged 7 commits into from
Nov 15, 2024
Merged

dy-static-file-server will consider initial input state as to be synced #159

merged 7 commits into from
Nov 15, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 15, 2024 •
edited
Loading

What do these changes do?

dy-static-file-server it did not consider the initial state of the inputs folder as to be synced. If the service starts and the files are already there. The test would fail.

Related issue number

Checklist

  • I think the code is well written
  • I updated the table of contents (make toc)
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@GitHK GitHK self-assigned this Nov 15, 2024
@GitHK GitHK added the t:bug Something isn't working label Nov 15, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 15, 2024
@GitHK GitHK changed the title Always trigger first dy-static-file-server will consider initial input state as to be synced Nov 15, 2024
@GitHK GitHK marked this pull request as ready for review November 15, 2024 10:38
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 15, 2024
View reviewed changes
Copy link

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit 29b389f into master Nov 15, 2024
2 checks passed
@GitHK GitHK deleted the always-trigger-first branch November 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

@pcrespov pcrespov Awaiting requested review from pcrespov

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@GitHK GitHK

Labels
t:bug Something isn't working
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
3 participants
@GitHK @giancarloromeo @matusdrobuliak66