Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Restrict client version for logstreaming e2e test and don't fail when cleaning up jobs in e2e tests #146

Merged
merged 129 commits into from
Apr 5, 2024
Merged

🐛 Restrict client version for logstreaming e2e test and don't fail when cleaning up jobs in e2e tests #146

merged 129 commits into from
Apr 5, 2024

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Apr 4, 2024 •
edited
Loading

What do these changes do?

  • Only run logstreaming test in e2e when client meets the condition version >= 0.6.5
  • @pcrespov for this reason the client e2e tests using client version 0.5.0 were all failing.
  • E2e client tests will continue failing against dalco deployments until those are fixed.
  • I also improved the clean up jobs in the e2e package so that it doesn't fail when a job cannot be cleaned up. This should make the postprocess step in the e2e tests more robust

Related issue/s

How to test

For internal developers

bisgaard-itis and others added 30 commits October 23, 2023 11:33
@bisgaard-itis
update workflow before publishing python package
9c15998
@bisgaard-itis
Merge branch 'master' of github.com:bisgaard-itis/osparc-simcore-clients
ab1bc1e
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
60c4f60
@bisgaard-itis
fix dependency issue and bump version
3aa7d70
@bisgaard-itis
Merge branch 'master' of github.com:bisgaard-itis/osparc-simcore-clients
a9810d4
@bisgaard-itis
point to website in project description
5d2ceb2
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
185195c
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
f58c10f
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
fdd75b7
@bisgaard-itis
fix broken dependency
11e369d
@bisgaard-itis
improve doc
e844983
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
c798687
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
55bdba4
@bisgaard-itis
add github token to download artifacts
9ce0911
@bisgaard-itis
ensure only read-access @wvangeit
39210ef
@bisgaard-itis
yet another attempt at downloading artifacts
50c487f
@bisgaard-itis
resolve merge conflicts
128a1a7
@bisgaard-itis
make sure to use repo that ran the trigger wf
3d8d1eb
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
3f2b07a
@bisgaard-itis
another attempt at fixing
48cf475
@bisgaard-itis
change owner
77d1e81
@bisgaard-itis
change repo owner
21b446b
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
10b5ce0
@bisgaard-itis
allow publishing to testpypi also when pr
d90cccc
@bisgaard-itis
minor change
b1561a4
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
2db2d81
@bisgaard-itis
revert minor (but breaking) change
a22c0c4
@bisgaard-itis
Merge branch 'ITISFoundation:master' into master
9a6a1e0
@bisgaard-itis
minor fix
a83b349
@bisgaard-itis
Merge branch 'master' of github.com:bisgaard-itis/osparc-simcore-clients
e4e07d7
@bisgaard-itis bisgaard-itis added the bug Something isn't working label Apr 4, 2024
@bisgaard-itis bisgaard-itis added this to the Enchanted Odyssey milestone Apr 4, 2024
@bisgaard-itis bisgaard-itis self-assigned this Apr 4, 2024
@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner April 4, 2024 11:16
@bisgaard-itis bisgaard-itis changed the title 🐛 Restrict client version for logstreaming e2e test 🐛 Restrict client version for logstreaming e2e test and don't fail when cleaning up jobs in e2e tests Apr 5, 2024
pcrespov
pcrespov approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! that is a very convenient decorator. thx!

clients/python/test/e2e/_utils.py Show resolved Hide resolved
clients/python/test/e2e/_utils.py Outdated Show resolved Hide resolved
@bisgaard-itis bisgaard-itis merged commit 355d741 into ITISFoundation:master Apr 5, 2024
9 checks passed
@bisgaard-itis bisgaard-itis deleted the 145-restrict-client-version-for-logstreaming-e2e-test branch April 5, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@bisgaard-itis bisgaard-itis

Labels
bug Something isn't working
Projects
None yet
Milestone
Enchanted Odyssey
Development

Successfully merging this pull request may close these issues.
3 participants
@bisgaard-itis @GitHK @pcrespov