✨Personalized resource limits: add DB table for max resources per user 🗃️

[sanderegg]

What do these changes do?

• adds a new table in the DB called services_limitations that allows one to define limitations in terms of RAM, #CPU, VRAM and #GPU to a group/cluster
• adds a bunch of tests in the postgres-database package to check that all this works as intended

We can currently override the resources a service uses per group ID via the services_specifications table. It has a number of drawbacks:

• all the instances of the overriden service will use the overriden specifications (if the user once needed a 96GB service, then all instances of that service will now require that amount)
• a bit complex to set up

Nevertheless it saved us when the dynamic sidecar was not stable and allowed the autoscaling to come up switftly.

This new table is the beginning of:

• project defined resources (the user may select more resources based on what he/she is allowed to use - which is defined in this new table)

Related issue/s

• relates to sim4life.io - WP4: Computational backend osparc-issues#950

How to test

cd packages/postgres-database
make install-dev
make tests

DevOps Checklist

[codecov]

Codecov Report

Merging #4335 (58c7cf0) into master (13e95f6) will increase coverage by 2.6%.
The diff coverage is 98.9%.

@@           Coverage Diff            @@
##           master   #4335     +/-   ##
========================================
+ Coverage    84.1%   86.7%   +2.6%     
========================================
  Files         976     840    -136     
  Lines       41881   37085   -4796     
  Branches      983     449    -534     
========================================
- Hits        35247   32183   -3064     
+ Misses       6424    4794   -1630     
+ Partials      210     108    -102     

Flag	Coverage Δ
integrationtests	68.1% <ø> (+16.1%)	⬆️
unittests	83.9% <98.9%> (+0.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...e/src/simcore_postgres_database/models/clusters.py	100.0% <ø> (ø)
...re_postgres_database/utils_services_limitations.py	98.7% <98.7%> (ø)
...se/src/simcore_postgres_database/models/_common.py	100.0% <100.0%> (ø)
...core_postgres_database/models/cluster_to_groups.py	100.0% <100.0%> (ø)
...e_postgres_database/models/services_limitations.py	100.0% <100.0%> (ø)

... and 179 files with indirect coverage changes

[elisabettai]

Sounds a big improvement! So this new table will make the changes in resources temporary? So this will not happen anymore?

all the instances of the overriden service will use the overriden specifications (if the user once needed a 96GB service, then all instances of that service will now require that amount)

Minor: in the PR description, I guess you wanted to add the direct link to the issue (and not the link via the Github project board).

[sanderegg]

Sounds a big improvement! So this new table will make the changes in resources temporary? So this will not happen anymore?

all the instances of the overriden service will use the overriden specifications (if the user once needed a 96GB service, then all instances of that service will now require that amount)

Minor: in the PR description, I guess you wanted to add the direct link to the issue (and not the link via the Github project board).

well hold a bit the horses ;) it's not yet complete. that is only the table.

[mrnicegyu11]

read it briefly, very cool stuff, thanks!

[pcrespov]

Well done! Code is spotless!

[codeclimate]

Code Climate has analyzed commit 58c7cf0 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication