-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Payments service: http clients #4831
✨ Payments service: http clients #4831
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4831 +/- ##
========================================
+ Coverage 82.9% 85.0% +2.1%
========================================
Files 1074 1163 +89
Lines 45637 48372 +2735
Branches 1040 1040
========================================
+ Hits 37859 41158 +3299
+ Misses 7546 6982 -564
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/payments/src/simcore_service_payments/services/payments_gateway.py
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_gateway.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/payments_gateway.py
Outdated
Show resolved
Hide resolved
services/payments/tests/unit/test_services_resource_usage_tracker.py
Outdated
Show resolved
Hide resolved
services/payments/src/simcore_service_payments/services/resource_usage_tracker.py
Show resolved
Hide resolved
3ec2c24
to
96c7faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
96c7faf
to
198c533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 🎉
17afb7d
to
8c37694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Code Climate has analyzed commit 651c970 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR introduces modules to deal with the http-api connections with RUT and the payment-gateway. Both modules have been created using common tools in
utils/http_client.py
(will eventually be moved toservicelib.fastapi
.simcore-service-payments echo-dotenv --minimal
Related issue/s
How to test
services/payments/tests/unit/test_services_resource_usage_tracker.py
DevOps
payments
service ( already added in.env-devel
)simcore-service-payments echo-dotenv
prints a valid dot-envfile (see --help for different options!). Example of usage:NOTE: this might be useful to generate an initial list of env-vars for a services.