Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Frontend] VIP Market PoC #6862

Merged
merged 39 commits into from
Dec 2, 2024
Merged

✨ [Frontend] VIP Market PoC #6862

merged 39 commits into from
Dec 2, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 28, 2024 •
edited
Loading

What do these changes do?

First prototype of the VIP Market, only available in master S4L.

Store

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 28, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 28, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 28, 2024
pcrespov
pcrespov approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@odeimaiz odeimaiz changed the title ✨ [Frontend] VIP Store POC ✨ [Frontend] VIP Store PoC Nov 28, 2024
sanderegg
sanderegg reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

matusdrobuliak66
matusdrobuliak66 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As an inpiration also N x N grid view might be nice:
image

@SCA-ZMT
Copy link

SCA-ZMT commented Nov 29, 2024

@matusdrobuliak66 I had implemented a grid view in the desktop a while ago as the 1st iteration, but it was universally disliked... so we switched to this split view of list + details there as well. :)

GitHK
GitHK reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mousy and fatty 👍

@odeimaiz odeimaiz changed the title ✨ [Frontend] VIP Store PoC ✨ [Frontend] VIP Market PoC Nov 29, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) November 29, 2024 12:56
@SCA-ZMT
Copy link

SCA-ZMT commented Nov 29, 2024

What about sorting by most recently added? It will probably be requested anyway. We also just got a request in the desktop version to add an option to only show the most recent version of each ViP instead of all of them.

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 29, 2024 •
edited
Loading

What about sorting by most recently added? It will probably be requested anyway. We also just got a request in the desktop version to add an option to only show the most recent version of each ViP instead of all of them.

In the sorting options, you will find sort by name (up and down) and sort by date (up&down)

SortByDate

jsaq007
jsaq007 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit 0c5a068 into ITISFoundation:master Dec 2, 2024
52 checks passed
@odeimaiz odeimaiz deleted the feature/vip-store branch December 2, 2024 12:22
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
7 participants
@odeimaiz @SCA-ZMT @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66