Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Username and Privacy settings #6916

Merged
merged 23 commits into from
Dec 9, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 6, 2024

What do these changes do?

This PR exposes

  • user's Username
  • privacy settings: hide fullname and hide email
  • getting ready to support username for other users

username

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 6, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 6, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 6, 2024
@odeimaiz odeimaiz changed the title ✨ [Frontend] username is the new unique identifier ✨ [Frontend] username for user Dec 6, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 6, 2024 14:34
@odeimaiz odeimaiz marked this pull request as draft December 6, 2024 14:37
@odeimaiz odeimaiz changed the title ✨ [Frontend] username for user ✨ [Frontend] username and privacy settings Dec 6, 2024
@odeimaiz odeimaiz marked this pull request as ready for review December 6, 2024 15:43
@odeimaiz odeimaiz enabled auto-merge (squash) December 6, 2024 15:51
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for a this round but I think we should need to polish some details.

Here are some thoughts:

  • Capitalize Username same as you do with first and last name.
  • When if fails, i have to improve the message and perhaps we can offer alternative usernames that are similar to the one the user enters.
  • I would also add more info on what is what (e.g. a small info icon or on hover on each field). Specially for privacy.
  • We also need to elaborate a bit more what are the implications of the privacy settings on the overall sharing etc ...

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz changed the title ✨ [Frontend] username and privacy settings ✨ [Frontend] Username and Privacy settings Dec 9, 2024
@odeimaiz
Copy link
Member Author

odeimaiz commented Dec 9, 2024

Good for a this round but I think we should need to polish some details.

Here are some thoughts:

  • Capitalize Username same as you do with first and last name.
  • When if fails, i have to improve the message and perhaps we can offer alternative usernames that are similar to the one the user enters.
  • I would also add more info on what is what (e.g. a small info icon or on hover on each field). Specially for privacy.
  • We also need to elaborate a bit more what are the implications of the privacy settings on the overall sharing etc ...

I capitalized Username

Copy link

sonarqubecloud bot commented Dec 9, 2024

@odeimaiz odeimaiz merged commit c74f4b0 into ITISFoundation:master Dec 9, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/user-name branch December 9, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants