π¨ improvements: return user email in licensed items, error msg, expose pricing plans ποΈ #7068
+839
β345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7068 +/- ##
===========================================
- Coverage 87.26% 63.06% -24.21%
===========================================
Files 1634 512 -1122
Lines 64264 23290 -40974
Branches 2051 0 -2051
===========================================
- Hits 56082 14688 -41394
- Misses 7845 8602 +757
+ Partials 337 0 -337
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
matusdrobuliak66
added
a:webserver
matusdrobuliak66
changed the title
matusdrobuliak66
requested review from
pcrespov,
sanderegg,
GitHK and
giancarloromeo
as code owners
GitHK
reviewed
Jan 23, 2025
.../simcore_service_resource_usage_tracker/services/background_task_periodic_heartbeat_check.py
Show resolved
Hide resolved
giancarloromeo
approved these changes
Jan 23, 2025
sanderegg
approved these changes
Jan 23, 2025
packages/models-library/src/models_library/api_schemas_webserver/licensed_items_checkouts.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/models/licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/models/licensed_items_purchases.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
Jan 23, 2025
.../simcore_service_resource_usage_tracker/services/background_task_periodic_heartbeat_check.py
Show resolved
Hide resolved
| product_name=req_ctx.product_name, | ||
| ) | ||
| webserver_pricing_unit_get = [ | ||
| PricingPlanGet( |
There was a problem hiding this comment.
As agreed, please create the adapter as a static member PricingPlanGet.from_domain_model
services/web/server/src/simcore_service_webserver/resource_usage/_pricing_plans_models.py
Outdated
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_pricing_plans.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/resource_usage/test_pricing_plans.py
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As required by @odeimaiz
Related issue/s
How to test
Dev-ops checklist