♻️Storage: Code refactoring prior to changes

[sanderegg]

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (69cf7cb) to head (7f938a5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (69cf7cb) and HEAD (7f938a5). Click for more details.

HEAD has 10 uploads less than BASE

Flag	BASE (69cf7cb)	HEAD (7f938a5)
unittests	30	22
integrationtests	6	4

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7088      +/-   ##
==========================================
- Coverage   87.26%   81.45%   -5.82%     
==========================================
  Files        1634     1433     -201     
  Lines       64264    58771    -5493     
  Branches     2051     1655     -396     
==========================================
- Hits        56082    47869    -8213     
- Misses       7845    10643    +2798     
+ Partials      337      259      -78     

Flag	Coverage Δ
integrationtests	51.71% <100.00%> (-13.07%)	⬇️
unittests	81.57% <64.28%> (-3.94%)	⬇️

Components	Coverage Δ
api	76.84% <ø> (ø)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	91.43% <100.00%> (ø)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	70.18% <ø> (ø)
pkg_service_library	74.06% <20.00%> (-0.07%)	⬇️
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	65.64% <50.00%> (-19.75%)	⬇️
agent	96.45% <ø> (ø)
api_server	88.06% <ø> (-2.49%)	⬇️
autoscaling	96.10% <ø> (ø)
catalog	90.32% <ø> (ø)
clusters_keeper	99.24% <ø> (ø)
dask_sidecar	91.26% <ø> (ø)
datcore_adapter	93.18% <ø> (ø)
director	76.92% <ø> (ø)
director_v2	84.58% <ø> (-6.69%)	⬇️
dynamic_scheduler	97.21% <ø> (ø)
dynamic_sidecar	88.81% <ø> (-0.95%)	⬇️
efs_guardian	90.39% <ø> (ø)
invitations	93.42% <ø> (ø)
osparc_gateway_server	∅ <ø> (∅)
payments	92.66% <ø> (ø)
resource_usage_tracker	89.28% <ø> (ø)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	72.80% <100.00%> (-12.12%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69cf7cb...7f938a5. Read the comment docs.

[sonarqubecloud]

Quality Gate failed

Failed conditions
2 Security Hotspots
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE