change approver emails subject line

media_commons_booking_app/src/client/routes/booking/hooks/useSubmitBooking.tsx

@@ -60,7 +60,8 @@ export default function useSubmitBooking(): [
         'approval_email',
         contents,
         recipient,
-        subject,
+        BookingStatusLabel.REQUESTED,
+        contents.title,
         ''
       )
     );

media_commons_booking_app/src/server/admin.ts

@@ -69,7 +69,14 @@ export const approveBooking = (id: string) => {
     const subject = 'Second Approval Request';
     const contents = bookingContents(id);
     const recipient = getSecondApproverEmail(process.env.BRANCH_NAME);
-    sendHTMLEmail('approval_email', contents, recipient, subject, '');
+    sendHTMLEmail(
+      'approval_email',
+      contents,
+      recipient,
+      BookingStatusLabel.PRE_APPROVED,
+      contents.title,
+      ''
+    );
   }
 };
 

media_commons_booking_app/src/server/emails.ts

@@ -3,21 +3,23 @@ import { Booking, BookingStatusLabel } from '../types';
 export const sendTextEmail = (
   targetEmail: string,
   status: BookingStatusLabel,
-  title: string,
+  eventTitle: string,
   body: string
 ) => {
-  const subj = `${status}: Media Commons request for \"${title}\"`;
+  const subj = `${status}: Media Commons request for \"${eventTitle}\"`;
   GmailApp.sendEmail(targetEmail, subj, body);
 };
 
 export const sendHTMLEmail = (
   templateName: string,
   contents: Booking,
   targetEmail: string,
-  title: string,
+  status: BookingStatusLabel,
+  eventTitle: string,
   body
 ) => {
   console.log('contents', contents);
+  const subj = `${status}: Media Commons request for \"${eventTitle}\"`;
   const htmlTemplate = HtmlService.createTemplateFromFile(templateName);
   for (const key in contents) {
     htmlTemplate[key] = contents[key] || '';
@@ -26,5 +28,5 @@ export const sendHTMLEmail = (
   const options = {
     htmlBody,
   };
-  GmailApp.sendEmail(targetEmail, title, body, options);
+  GmailApp.sendEmail(targetEmail, subj, body, options);
 };