-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NDTensors] [ITensors] Excise unneeded submodules #1601
Conversation
I plan to merge and register this once TypeParameterAccessors.jl is registered in the General registry (in progress here: JuliaRegistries/General#124121). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
==========================================
+ Coverage 78.76% 79.44% +0.67%
==========================================
Files 75 64 -11
Lines 5233 5083 -150
==========================================
- Hits 4122 4038 -84
+ Misses 1111 1045 -66 ☔ View full report in Codecov by Sentry. |
This PR deletes a big set of submodules of NDTensors and moves them to separate repositories, for example
NDTensors.BlockSparseArrays
has been moved to the new BlockSparseArrays.jl repository. Most will be unregistered (potentially interdependent) packages for the time being, while TypeParameterAccessors.jl will be registered since it is used extensively throughoutNDTensors.jl
and also is used by some of the new packages.So far most of the packages are kept as-is, however
GradedAxes
has been renamed toGradedUnitRanges
.I followed the instructions here to preserve the git history of the subfolders.
To-do:
NDTensors
and also other packages.NDTensors
that was depending onDiagonalArrays
, so that it can be removed as a dependency.[sources]
section in their Project.toml (see https://pkgdocs.julialang.org/v1/toml-files/#The-%5Bsources%5D-section).The packages should be set up in a uniform way using ITensorPkgSkeleton.jl. The following packages have been set up based on the code removed in this PR:
Here are package extensions that need to be set up for compatibility with
NDTensors.jl
andITensors.jl
, which will be addressed in future work:NamedDimsArraysNDTensorsExt
andNamedDimsArraysITensorsExt
NamedDimsArrays.jl#3.)NamedDimsArraysNDTensorsExt
andNamedDimsArraysITensorsExt
NamedDimsArrays.jl#3.)Other libraries to split off in future PRs are (these are being used in some tests which requires loading NDTensors as a test dependency):