-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESSI-2062] fix iiif urls unaware of external_storage #648
base: main
Are you sure you want to change the base?
Conversation
e6666e6
to
f4cf9b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulling these IIIF behaviors into this service presents an opportunity to make some spec tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlpierce spec tests added, which did indeed lead to some revisions!
@dlpierce for the refactoring pass, I didn't want to change any logic, but there's an opportunity to simplify/unify logic if it was unintentionally variable, originally:
UPDATE: I have pushed 3rd and 4th commits for the above, which can be kept or dropped if we don't actually want to change any of the logic |
bcbc848
to
2b0ecc7
Compare
2b0ecc7
to
2e3f17c
Compare
Refactors lookup of IIIF image server URLs (in a manner aware of external_storage settings), and applies that logic where not yet present.
New/modified infrastructure:
Hyrax.config.iiif_image_url_builder
,Hyrax.config.iiif_info_url_builder
)Updated cases, adding handling of external storage:
Refactoring cases: