Skip to content

Commit

Permalink
Changed the core version number in the pom.xml. Removed some comments…
Browse files Browse the repository at this point in the history
… now that we've reviewed the code.
  • Loading branch information
pcc-cahilp committed Nov 8, 2024
1 parent 4047f11 commit dad5b7c
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 44 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
release branch is labeled <major>.<minor>.<patch>-izgw-core-SNAPSHOT
main branch is labeled <major>.<minor>.<patch>-izgw-core-RELEASE
-->
<version>2.2.0-IGDD-1765_optional_mtls_plus_jwt-SNAPSHOT</version>
<version>2.1.5-IGDD-1765_optional_mtls_plus_jwt-SNAPSHOT</version>
<packaging>jar</packaging>
<name>IZ Gateway Core 2.0</name>
<description>IZ Gateway Core contains the core code for the IZ Gateway Hub and Transformation services</description>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ public abstract class EndPointInfo extends HostInfo implements Serializable {
@JsonProperty
protected String organization;

/*
TODO: Discuss during code review. serialNumber changes to String because info
in the JWT that we use for serialNumber is not always a number.
*/
@Schema(description="The serial number associated with the with certificate on the endpoint.")
@JsonProperty
protected String serialNumber;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public boolean accessAllowed(HttpServletRequest req, HttpServletResponse resp) {
if (Boolean.FALSE.equals(check)) { // NOSONAR Null is still possible here, SONAR flags it as always true
log.error("Access denied to protected URL {} address by {} at {}", path, user, host);
resp.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
return false; // TODO: PCahill - discuss at code review - I assume this should be false here
return false;
}

if (isSwagger(path, user)) {
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/gov/cdc/izgateway/soap/net/MessageSender.java
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,7 @@ public static void logDestinationCertificates(HttpURLConnection con) {
if (destination.isConnected() && con instanceof HttpsURLConnection conx) {
try {
X509Certificate[] certs = (X509Certificate[]) conx.getServerCertificates();
// TODO Paul - Principal related code
// need to fix this - may need to break out source and destination info because destination won't have a principal'
destination.setCertificate(certs[0]);
// destination.setPrincipal(RequestContext.getPrincipal());
destination.setCipherSuite(conx.getCipherSuite());
destination.setConnected(true);
} catch (SSLPeerUnverifiedException | IllegalStateException ex) {
Expand Down
35 changes: 0 additions & 35 deletions src/main/resources/sample.puml

This file was deleted.

0 comments on commit dad5b7c

Please sign in to comment.