Igdd 1589 enable fhir datatype conversion #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcahillai
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I strongly recommend pulling the code and looking at it locally rather than trying to review in Files changed (most of which were deleted due to an inadvertant push of dependencies).
See https://vigilant-adventure-g62mzg1.pages.github.io/current/apidocs/index.html for the java doc (public methods are fully documented).
Focus on the following files for this review:
converter/DatatypeConverter.java
converter/MessageParser.java
converter/package-info.java
datatype/AddressParser.java
datatype/ContactPointParser.java
datatype/DatatypeParser.java
datatype/HumanNameParser.java
segment/AbstractSegmentParser.java
segment/AbstractStructureParser.java
segment/ComesFrom.java
segment/ERRParser.java
segment/MSAParser.java
segment/MSHParser.java
segment/package-info.java
segment/PIDParser.java
segment/QAKParser.java
segment/QPDParser.java
segment/StructureParser.java
utils/Mapping.java
utils/package-info.java
utils/ParserUtils.java
utils/PathUtils.java
utils/Systems.java
utils/TextUtils.java