fix: Secure all the endpoints

IZIVIA · Jan 9, 2024 · 0b179cf · 0b179cf
1 parent 312ebfc
commit 0b179cf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/...it-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/modules/credentials/CredentialsServer.kt b/...it-2.2.1/src/main/kotlin/com/izivia/ocpi/toolkit/modules/credentials/CredentialsServer.kt
@@ -13,8 +13,7 @@ class CredentialsServer(
     override suspend fun registerOn(transportServer: TransportServer) {
         transportServer.handle(
             method = HttpMethod.GET,
-            path = basePathSegments,
-            secured = false
+            path = basePathSegments
         ) { req ->
             req.httpResponse {
                 service.get(
@@ -25,8 +24,7 @@ class CredentialsServer(
 
         transportServer.handle(
             method = HttpMethod.POST,
-            path = basePathSegments,
-            secured = false
+            path = basePathSegments
         ) { req ->
             req.httpResponse {
                 service.post(
@@ -39,8 +37,7 @@ class CredentialsServer(
 
         transportServer.handle(
             method = HttpMethod.PUT,
-            path = basePathSegments,
-            secured = false
+            path = basePathSegments
         ) { req ->
             req.httpResponse {
                 service.put(
@@ -53,8 +50,7 @@ class CredentialsServer(
 
         transportServer.handle(
             method = HttpMethod.DELETE,
-            path = basePathSegments,
-            secured = false
+            path = basePathSegments
         ) { req ->
             req.httpResponse {
                 service.delete(

diff --git a/...kit-2.2.1/src/test/kotlin/com/izivia/ocpi/toolkit/samples/common/Http4kTransportServer.kt b/...kit-2.2.1/src/test/kotlin/com/izivia/ocpi/toolkit/samples/common/Http4kTransportServer.kt
@@ -30,7 +30,6 @@ class Http4kTransportServer(
         method: HttpMethod,
         path: List<PathSegment>,
         queryParams: List<String>,
-        secured: Boolean,
         filters: List<(request: HttpRequest) -> Unit>,
         callback: suspend (request: HttpRequest) -> HttpResponse
     ) {
@@ -60,7 +59,7 @@ class Http4kTransportServer(
                         body = req.bodyString()
                     )
                         .also { httpRequest ->
-                            if (secured) runBlocking { secureFilter(httpRequest) }
+                            runBlocking { secureFilter(httpRequest) }
                         }
                         .also { httpRequest -> filters.forEach { filter -> filter(httpRequest) } }
                         .let { httpRequest ->

diff --git a/transport/src/main/kotlin/com/izivia/ocpi/toolkit/transport/TransportServer.kt b/transport/src/main/kotlin/com/izivia/ocpi/toolkit/transport/TransportServer.kt
@@ -18,7 +18,6 @@ interface TransportServer {
         method: HttpMethod,
         path: List<PathSegment>,
         queryParams: List<String> = emptyList(),
-        secured: Boolean = true,
         filters: List<(request: HttpRequest) -> Unit> = emptyList(),
         callback: suspend (request: HttpRequest) -> HttpResponse
     )