-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed code transferred to GPURigidRegistrationLib and fetch the code from GitHub instead #456
base: master
Are you sure you want to change the base?
Removed code transferred to GPURigidRegistrationLib and fetch the code from GitHub instead #456
Conversation
FetchContent_Declare( | ||
GPURigidRegistrationLib | ||
GIT_REPOSITORY https://github.com/IbisNeuronav/GPURigidRegistrationLib.git | ||
GIT_TAG main ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default the binary directory is ${CMAKE_BINARY_DIR}/_deps, I added the following lines to make it more consistent with other dependencies:
set(FETCHCONTENT_BASE_DIR ${IBIS_EXTERNAL_DEPENDENCIES_DIR}/GPUReg CACHE PATH "Directory under which to collect all populated content" FORCE)
FetchContent_Declare(
GPURigidRegistrationLib
GIT_REPOSITORY https://github.com/IbisNeuronav/GPURigidRegistrationLib.git
GIT_TAG main
SOURCE_DIR ${FETCHCONTENT_BASE_DIR}/src
BINARY_DIR ${FETCHCONTENT_BASE_DIR}/build
SUBBUILD_DIR ${FETCHCONTENT_BASE_DIR}/subbuild
)
I reduced path names to ${IBIS_EXTERNAL_DEPENDENCIES_DIR}/GPUReg, still does not compile on windows with the following error message:
|
The latest changes in master branch should be applied, otherwise SuperBuild fails. |
e215c94
to
cee4704
Compare
I rebased on latest master, integrated @hgueziri's changes and shortened the path even further (GR instead GPUReg). The path is now short enough to compile when building in the shortest possible base directory ( |
We could also consider to reduce path lengths in https://github.com/hgueziri/GPURigidRegistrationLib repo |
No description provided.