Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build all plugins in SuperBuild #509

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

errollgarner
Copy link
Contributor

  • CI build now builds all plugins

@hgueziri
Copy link
Member

When the option is turned on then off, cmake should reset to default plugin:

  • ContourSurface
  • LabelVolumeToSurface
  • LandmarkRegistration
  • USAcquisition

@errollgarner
Copy link
Contributor Author

@hgueziri, the solution in this last commit has the required behaviour. I think it is overall a better solution as it doesn't affect the state of the cache. So setting build_all to on then off from any set of selected plugins (not just defaults) will result in exactly that set being selected afterwards. The only downside is that it requires modules that have dependencies to not only check if their dependencies are selected, but actively set them on (as was the case for PedicleScrewNavigation) when they weren't already.

@errollgarner
Copy link
Contributor Author

Worthy of note: this explicit activation of dependencies doesn't affect the cache and is therefore not persistent upon deselection of the build_all option.

@errollgarner errollgarner merged commit a2d0a8b into IbisNeuronav:master Jun 28, 2023
@errollgarner errollgarner deleted the CIBuildAllPlugins branch November 15, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants