Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates #62

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Dependency updates #62

merged 3 commits into from
Dec 1, 2023

Conversation

onyxraven
Copy link
Member

@onyxraven onyxraven commented Nov 21, 2023 •
edited
Loading

Background

  • go get -u && go tidy to update dependencies
    • cobra and the md generator for cobra were updated
  • github actions updates
  • lint fixes
  • version agreement in go.mod

This is in prep to work on the pending PR #61

Versioning

This PR is at most a patch, but probably will roll up into the next update (no criticals)

Tasks

  • Manual testing

@onyxraven onyxraven self-assigned this Nov 21, 2023
@ibcheckmarx
Copy link

ibcheckmarx commented Nov 21, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 664d8f65-d83d-4f46-8948-be5e305d5ce2

No New Or Fixed Issues Found

ibottamike
ibottamike previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@ibottamike ibottamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming go mod tidy did its thing for the version. One small question on version mismatch.

.github/workflows/lint.yaml Show resolved Hide resolved
@onyxraven onyxraven merged commit c3d660f into main Dec 1, 2023
4 checks passed
@onyxraven onyxraven deleted the dependency-updates branch December 1, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibottamike ibottamike ibottamike left review comments

@elementalvoid elementalvoid Awaiting requested review from elementalvoid elementalvoid is a code owner

@physik932 physik932 Awaiting requested review from physik932 physik932 is a code owner

Assignees

@onyxraven onyxraven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onyxraven @ibcheckmarx @ibottamike