[BUGFIX] Compatibility with PHP 8.4 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the changed whitespaces in |
koehnlein
force-pushed
the
fix-deprecation-warnings-php84
branch
5 times, most recently
from
2c92fcb to
31b0acb
Compare
IchHabRecht
reviewed
Jan 24, 2025
| /** | ||
| * Build and return instance of TcaDatabaseRecord based on TYPO3 version | ||
| */ | ||
| protected function getTcaDatabaseRecordInstance(): TcaDatabaseRecord |
There was a problem hiding this comment.
I don't think the introduction of a new function is necessary as obsolete constructor arguments are simply ignored.
There was a problem hiding this comment.
I changed it and always pass the constructor argument directly
koehnlein
force-pushed
the
fix-deprecation-warnings-php84
branch
2 times, most recently
from
9d81e2a to
15335a9
Compare
koehnlein
force-pushed
the
fix-deprecation-warnings-php84
branch
2 times, most recently
from
8dfad27 to
0afa379
Compare
|
I have no idea, why there are two cancelled GitHub actions 🤷♂️ |
IchHabRecht
force-pushed
the
fix-deprecation-warnings-php84
branch
2 times, most recently
from
9b2299d to
e1ac18d
Compare
As of PHP 8.4 implicitly declaring function parameters nullable is deprecated. Explicitly nullable types have been available since PHP 7.1 See: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
…reate constructor argument
IchHabRecht
force-pushed
the
fix-deprecation-warnings-php84
branch
from
e1ac18d to
3e46ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #163 but with adapted tests