Move source icon in incident detail to the header

Icinga · May 3, 2024 · a76399f · a76399f
1 parent 3224f65
commit a76399f
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 18 deletions.
diff --git a/application/controllers/EventController.php b/application/controllers/EventController.php
@@ -25,7 +25,7 @@ public function indexAction(): void
         $id = $this->params->getRequired('id');
 
         $query = Event::on(Database::get())
-            ->with(['object', 'object.source', 'incident', 'incident.object'])
+            ->with(['object', 'object.source', 'incident', 'incident.object', 'incident.object.source'])
             ->withColumns(['object.id_tags', 'incident.object.id_tags'])
             ->filter(Filter::equal('event.id', $id));
 

diff --git a/application/controllers/IncidentsController.php b/application/controllers/IncidentsController.php
@@ -29,7 +29,7 @@ public function indexAction(): void
         $this->addTitleTab(t('Incidents'));
 
         $incidents = Incident::on(Database::get())
-            ->with('object')
+            ->with(['object', 'object.source'])
             ->withColumns('object.id_tags');
 
         $limitControl = $this->createLimitControl();

diff --git a/library/Notifications/Widget/Detail/IncidentDetail.php b/library/Notifications/Widget/Detail/IncidentDetail.php
@@ -97,7 +97,6 @@ protected function createHistory()
             ->with([
                 'event',
                 'incident.object',
-                'incident.object.source',
                 'contact',
                 'rule',
                 'rule_escalation',

diff --git a/library/Notifications/Widget/ItemList/IncidentHistoryListItem.php b/library/Notifications/Widget/ItemList/IncidentHistoryListItem.php
@@ -9,7 +9,6 @@
 use Icinga\Module\Notifications\Model\Event;
 use Icinga\Module\Notifications\Model\IncidentHistory;
 use Icinga\Module\Notifications\Model\Objects;
-use Icinga\Module\Notifications\Widget\SourceIcon;
 use ipl\Html\BaseHtmlElement;
 use ipl\Web\Widget\IcingaIcon;
 use ipl\Web\Common\BaseListItem;
@@ -76,11 +75,6 @@ protected function assembleHeader(BaseHtmlElement $header): void
         }
 
         $header->addHtml($this->createCaption());
-        if ($this->item->type === 'opened' || $this->item->type === 'incident_severity_changed') {
-            $header->add(
-                (new SourceIcon(SourceIcon::SIZE_BIG))->addHtml($this->item->incident->object->source->getIcon())
-            );
-        }
 
         $header->add(new TimeAgo($this->item->time->getTimestamp()));
     }

diff --git a/library/Notifications/Widget/ItemList/IncidentListItem.php b/library/Notifications/Widget/ItemList/IncidentListItem.php
@@ -8,8 +8,12 @@
 use Icinga\Module\Notifications\Common\Links;
 use Icinga\Module\Notifications\Model\Incident;
 use Icinga\Module\Notifications\Model\Objects;
+use Icinga\Module\Notifications\Model\Source;
+use Icinga\Module\Notifications\Widget\SourceIcon;
+use ipl\Html\Attributes;
 use ipl\Html\BaseHtmlElement;
 use ipl\Html\Html;
+use ipl\Html\HtmlElement;
 use ipl\Web\Common\BaseListItem;
 use ipl\Web\Widget\Icon;
 use ipl\Web\Widget\Link;
@@ -73,19 +77,22 @@ protected function assembleTitle(BaseHtmlElement $title): void
     protected function assembleHeader(BaseHtmlElement $header): void
     {
         $header->add($this->createTitle());
+        $meta = new HtmlElement('span', Attributes::create(['class' => 'meta']));
+
+        /** @var Source $source */
+        $source = $this->item->object->source;
+        $meta->addHtml((new SourceIcon(SourceIcon::SIZE_BIG))->addHtml($source->getIcon()));
 
         if ($this->item->recovered_at !== null) {
-            $header->add(Html::tag(
-                'span',
-                ['class' => 'meta'],
-                [
-                    'closed ',
-                    new TimeAgo($this->item->recovered_at->getTimestamp())
-                ]
-            ));
+            $meta->add([
+                'closed ',
+                new TimeAgo($this->item->recovered_at->getTimestamp())
+            ]);
         } else {
-            $header->add(new TimeSince($this->item->started_at->getTimestamp()));
+            $meta->addHtml(new TimeSince($this->item->started_at->getTimestamp()));
         }
+
+        $header->addHtml($meta);
     }
 
     protected function getSeverityIcon(): string