Move source icon in incident detail to the header

[raviks789]

fixes #161

[sukhwinder33445]

• The icon is no longer aligned in the center due to this change (bae69e5)
• The icons in the list should be statically aligned.

[ncosta-ic]

@raviks789 @sukhwinder33445

• The icon is no longer aligned in the center due to this change (bae69e5)

• The icons in the list should be statically aligned.

I stumbled accross the same problem and fixed it by adding a margin-top: .15em to the i.icon rule for .source-icon in public/css/common.less
I will not include this change in my PR (#166) but it should be an easy fix.

[sukhwinder33445]

I stumbled accross the same problem and fixed it by adding a margin-top: .15em to the i.icon rule for .source-icon in public/css/common.less

It should also be fixed if you only remove this change. (bae69e5)

[ncosta-ic]

I stumbled accross the same problem and fixed it by adding a margin-top: .15em to the i.icon rule for .source-icon in public/css/common.less

It should also be fixed if you only remove this change. (bae69e5)

(The red box should be aligned to the cyan guides)

I quickly compared all three variants:

• vertical-align: top
• vertical-align: top, margin-top: .15em
• without both css rules

From my point of view, the second option is also not quite right, but it's much closer to be perfectly aligned than the other two variants.

EDIT: The change in the icon placement is caused by Icinga/ipl-web#221

[nilmerg]

The placement of the icon should be fixed separately.

[nilmerg]

The placement of the icon should be fixed separately.

With this, I meant the placement of the icon inside the circle. Essentially, my answer to the discussion above.

Now, you've dismissed your own change that added a small gap to the right. I didn't mean you to do this! I still think it's suitable and a visual improvement. If applied to the incident and events list.

[nilmerg]

please rebase and fix conflicts

outdated