Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hook error handling #241

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix hook error handling #241

merged 2 commits into from
Jul 22, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jul 19, 2024

No description provided.

@nilmerg nilmerg added the bug Something isn't working label Jul 19, 2024
@nilmerg nilmerg self-assigned this Jul 19, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 19, 2024
@nilmerg nilmerg requested a review from yhabteab July 19, 2024 14:03
yhabteab
yhabteab approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now, but the action lists are no longer clickable without Icinga DB Web.

@nilmerg
Copy link
Member Author

nilmerg commented Jul 22, 2024

That's a known limitation, and already being worked on: Icinga/ipl-web#225

@nilmerg nilmerg merged commit 9cf10a4 into main Jul 22, 2024
22 checks passed
@nilmerg nilmerg deleted the fix-hook-error-handling branch July 22, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab approved these changes

Assignees

@nilmerg nilmerg

Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilmerg @yhabteab