internal/object: Fix gosec G115 #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion of an int64 to an uint64 was marked as a potential overflow, since it might lose precision. However, in this case this should be of no issue since only the binary representation matters, not the actual numeric value. So a "nolint" tag was added next to an explanatory comment. Fixes #289.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion of an int64 to an uint64 was marked as a potential overflow, since it might lose precision. However, in this case this should be of no issue since only the binary representation matters, not the actual numeric value.
So a "nolint" tag was added next to an explanatory comment.
Fixes #289.