hostgroups: Preserve filters in details

Icinga · Jul 19, 2024 · 2c9e182 · 2c9e182
1 parent c857c38
commit 2c9e182
Show file tree

Hide file tree

Showing 2 changed files with 110 additions and 24 deletions.
diff --git a/application/controllers/HostgroupController.php b/application/controllers/HostgroupController.php
@@ -4,79 +4,158 @@
 
 namespace Icinga\Module\Icingadb\Controllers;
 
-use Icinga\Exception\NotFoundError;
+use Icinga\Module\Icingadb\Common\Links;
 use Icinga\Module\Icingadb\Model\Host;
 use Icinga\Module\Icingadb\Model\Hostgroupsummary;
 use Icinga\Module\Icingadb\Redis\VolatileStateResults;
+use Icinga\Module\Icingadb\Web\Control\SearchBar\ObjectSuggestions;
+use Icinga\Module\Icingadb\Web\Control\ViewModeSwitcher;
 use Icinga\Module\Icingadb\Web\Controller;
 use Icinga\Module\Icingadb\Widget\ItemList\HostList;
 use Icinga\Module\Icingadb\Widget\ItemTable\HostgroupTableRow;
 use ipl\Html\Html;
 use ipl\Stdlib\Filter;
+use ipl\Web\Control\LimitControl;
+use ipl\Web\Control\SortControl;
+use ipl\Web\Url;
 
 class HostgroupController extends Controller
 {
-    /** @var Hostgroupsummary The host group object */
-    protected $hostgroup;
+    /** @var string */
+    protected $hostgroupName;
 
     public function init()
     {
         $this->assertRouteAccess('hostgroups');
+        $this->hostgroupName = $this->params->shiftRequired('name');
+    }
 
-        $this->addTitleTab(t('Host Group'));
-
-        $name = $this->params->getRequired('name');
-
+    /**
+     * Fetch the host group object
+     *
+     * @return Hostgroupsummary
+     */
+    protected function fetchHostgroup(): Hostgroupsummary
+    {
         $query = Hostgroupsummary::on($this->getDb());
 
         foreach ($query->getUnions() as $unionPart) {
-            $unionPart->filter(Filter::equal('hostgroup.name', $name));
+            $unionPart->filter(Filter::equal('hostgroup.name', $this->hostgroupName));
         }
 
         $this->applyRestrictions($query);
 
+        /** @var Hostgroupsummary $hostgroup */
         $hostgroup = $query->first();
         if ($hostgroup === null) {
-            throw new NotFoundError(t('Host group not found'));
+            $this->httpNotFound(t('Host group not found'));
         }
 
-        $this->hostgroup = $hostgroup;
-        $this->setTitle($hostgroup->display_name);
+        return $hostgroup;
     }
 
     public function indexAction()
     {
         $db = $this->getDb();
+        $hostgroup = $this->fetchHostgroup();
 
         $hosts = Host::on($db)->with(['state', 'state.last_comment', 'icon_image']);
         $hosts
             ->setResultSetClass(VolatileStateResults::class)
-            ->filter(Filter::equal('hostgroup.id', $this->hostgroup->id));
+            ->filter(Filter::equal('hostgroup.id', $hostgroup->id));
         $this->applyRestrictions($hosts);
 
         $limitControl = $this->createLimitControl();
         $paginationControl = $this->createPaginationControl($hosts);
+        $sortControl = $this->createSortControl(
+            $hosts,
+            [
+                'host.display_name'                                          => t('Name'),
+                'host.state.severity desc,host.state.last_state_change desc' => t('Severity'),
+                'host.state.soft_state'                                      => t('Current State'),
+                'host.state.last_state_change desc'                          => t('Last State Change')
+            ]
+        );
         $viewModeSwitcher = $this->createViewModeSwitcher($paginationControl, $limitControl);
 
-        $hostList = (new HostList($hosts->execute()))
-            ->setViewMode($viewModeSwitcher->getViewMode());
+        $searchBar = $this->createSearchBar($hosts, [
+            $limitControl->getLimitParam(),
+            $sortControl->getSortParam(),
+            $viewModeSwitcher->getViewModeParam(),
+            'name'
+        ])->setSuggestionUrl(Url::fromPath(
+            'icingadb/hostgroup/complete',
+            [
+                'name' => $this->hostgroupName,
+                '_disableLayout' => true,
+                'showCompact' => true
+            ]
+        ));
+
+        if ($searchBar->hasBeenSent() && ! $searchBar->isValid()) {
+            if ($searchBar->hasBeenSubmitted()) {
+                $filter = $this->getFilter();
+            } else {
+                $this->addControl($searchBar);
+                $this->sendMultipartUpdate();
+                return;
+            }
+        } else {
+            $filter = $searchBar->getFilter();
+        }
+
+        $hosts->filter($filter);
 
         yield $this->export($hosts);
 
+        $hostList = (new HostList($hosts->execute()))
+            ->setViewMode($viewModeSwitcher->getViewMode());
+
         // ICINGAWEB_EXPORT_FORMAT is not set yet and $this->format is inaccessible, yeah...
         if ($this->getRequest()->getParam('format') === 'pdf') {
-            $this->addContent(new HostgroupTableRow($this->hostgroup));
+            $this->addContent(new HostgroupTableRow($hostgroup));
             $this->addContent(Html::tag('h2', null, t('Hosts')));
         } else {
-            $this->addControl(new HostgroupTableRow($this->hostgroup));
+            $this->addControl(new HostgroupTableRow($hostgroup));
         }
 
         $this->addControl($paginationControl);
-        $this->addControl($viewModeSwitcher);
+        $this->addControl($sortControl);
         $this->addControl($limitControl);
+        $this->addControl($viewModeSwitcher);
+        $this->addControl($searchBar);
+        $continueWith = $this->createContinueWith(Links::hostsDetails(), $searchBar);
 
         $this->addContent($hostList);
 
+        if (! $searchBar->hasBeenSubmitted() && $searchBar->hasBeenSent()) {
+            $this->sendMultipartUpdate($continueWith);
+        }
+
+        $this->addTitleTab(t('Host Group'));
+        $this->setTitle($hostgroup->display_name);
         $this->setAutorefreshInterval(10);
     }
+
+    public function completeAction()
+    {
+        $suggestions = new ObjectSuggestions();
+        $suggestions->setModel(Host::class);
+        $suggestions->setBaseFilter(Filter::equal('hostgroup.name', $this->hostgroupName));
+        $suggestions->forRequest($this->getServerRequest());
+        $this->getDocument()->add($suggestions);
+    }
+
+    public function searchEditorAction()
+    {
+        $editor = $this->createSearchEditor(Host::on($this->getDb()), [
+            LimitControl::DEFAULT_LIMIT_PARAM,
+            SortControl::DEFAULT_SORT_PARAM,
+            ViewModeSwitcher::DEFAULT_VIEW_MODE_PARAM,
+            'name'
+        ]);
+
+        $this->getDocument()->add($editor);
+        $this->setTitle(t('Adjust Filter'));
+    }
 }
diff --git a/library/Icingadb/Widget/ItemTable/BaseHostGroupItem.php b/library/Icingadb/Widget/ItemTable/BaseHostGroupItem.php
@@ -34,8 +34,8 @@ protected function init(): void
 
     protected function createSubject(): BaseHtmlElement
     {
-        return isset($this->table)
-            ? new Link(
+        if (isset($this->table)) {
+            $link = new Link(
                 $this->item->display_name,
                 Links::hostgroup($this->item),
                 [
@@ -45,12 +45,19 @@ protected function createSubject(): BaseHtmlElement
                         $this->item->display_name
                     )
                 ]
-            )
-            : new HtmlElement(
-                'span',
-                Attributes::create(['class' => 'subject']),
-                Text::create($this->item->display_name)
             );
+            if ($this->table->hasBaseFilter()) {
+                $link->getUrl()->setFilter($this->table->getBaseFilter());
+            }
+
+            return $link;
+        }
+
+        return new HtmlElement(
+            'span',
+            Attributes::create(['class' => 'subject']),
+            Text::create($this->item->display_name)
+        );
     }
 
     protected function createCaption(): BaseHtmlElement