Add HasRootProblem behavior for service

Icinga · Oct 8, 2024 · 3914d94 · 3914d94
1 parent 7f3124b
commit 3914d94
Show file tree

Hide file tree

Showing 4 changed files with 95 additions and 8 deletions.
diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
@@ -38,13 +38,15 @@ public function init()
         $name = $this->params->getRequired('name');
         $hostName = $this->params->getRequired('host.name');
 
-        $query = Service::on($this->getDb())->with([
-            'state',
-            'icon_image',
-            'host',
-            'host.state',
-            'timeperiod'
-        ]);
+        $query = Service::on($this->getDb())
+            ->withColumns(['has_root_problem'])
+            ->with([
+                'state',
+                'icon_image',
+                'host',
+                'host.state',
+                'timeperiod'
+            ]);
         $query
             ->setResultSetClass(VolatileStateResults::class)
             ->filter(Filter::all(

diff --git a/library/Icingadb/Model/Behavior/HasRootProblem.php b/library/Icingadb/Model/Behavior/HasRootProblem.php
@@ -0,0 +1,78 @@
+<?php
+
+/* Icinga DB Web | (c) 2024 Icinga GmbH | GPLv2 */
+
+namespace Icinga\Module\Icingadb\Model\Behavior;
+
+use Icinga\Module\Icingadb\Model\DependencyEdge;
+use ipl\Orm\AliasedExpression;
+use ipl\Orm\ColumnDefinition;
+use ipl\Orm\Exception\InvalidColumnException;
+use ipl\Orm\Query;
+use ipl\Sql\Expression;
+use ipl\Stdlib\Filter;
+use ipl\Orm\Contract\RewriteColumnBehavior;
+use ipl\Orm\Contract\QueryAwareBehavior;
+
+/**
+ * Behavior to check if the object has a root problem
+ */
+class HasRootProblem implements RewriteColumnBehavior, QueryAwareBehavior
+{
+    /** @var Query */
+    protected $query;
+
+    public function setQuery(Query $query): self
+    {
+        $this->query = $query;
+
+        return $this;
+    }
+
+    public function rewriteColumn($column, ?string $relation = null)
+    {
+        if ($this->isSelectableColumn($column)) {
+            $path = 'from.dependency_node';
+            $subQueryRelation = $relation !== null ? $relation . $path : $path;
+            $subQuery = $this->query->createSubQuery(new DependencyEdge(), $subQueryRelation)
+                ->limit(1)
+                ->columns([new Expression('1')]);
+
+            $subQuery->getSelectBase()->join(
+                ['root_dependency' => 'dependency'],
+                [$subQuery->getResolver()->getAlias($subQuery->getModel()) . '.dependency_id = root_dependency.id']
+            )->join(
+                ['root_dependency_state' => 'dependency_state'],
+                ['root_dependency.id = root_dependency_state.dependency_id']
+            )->where(new Expression("root_dependency_state.failed = 'y'"));
+
+            $column = $relation !== null ? str_replace('.', '_', $relation) . "_$column" : $column;
+
+            $alias = $this->query->getDb()->quoteIdentifier([$column]);
+
+            list($select, $values) = $this->query->getDb()
+                ->getQueryBuilder()
+                ->assembleSelect($subQuery->assembleSelect());
+
+            return new AliasedExpression($alias, "($select)", null, ...$values);
+        }
+    }
+
+    public function isSelectableColumn(string $name): bool
+    {
+        return $name === 'has_root_problem';
+    }
+
+    public function rewriteColumnDefinition(ColumnDefinition $def, string $relation): void
+    {
+    }
+
+    public function rewriteCondition(Filter\Condition $condition, $relation = null): void
+    {
+        $column = substr($condition->getColumn(), strlen($relation));
+
+        if ($this->isSelectableColumn($column)) {
+            throw new InvalidColumnException($column, $this->query->getModel());
+        }
+    }
+}
diff --git a/library/Icingadb/Model/Service.php b/library/Icingadb/Model/Service.php
@@ -6,6 +6,7 @@
 
 use Icinga\Module\Icingadb\Common\Auth;
 use Icinga\Module\Icingadb\Model\Behavior\BoolCast;
+use Icinga\Module\Icingadb\Model\Behavior\HasRootProblem;
 use Icinga\Module\Icingadb\Model\Behavior\ReRoute;
 use ipl\Orm\Behavior\Binary;
 use ipl\Orm\Behaviors;
@@ -194,6 +195,8 @@ public function createBehaviors(Behaviors $behaviors)
             'zone_id',
             'command_endpoint_id'
         ]));
+
+        $behaviors->add(new HasRootProblem());
     }
 
     public function createDefaults(Defaults $defaults)

diff --git a/library/Icingadb/Widget/Detail/ObjectDetail.php b/library/Icingadb/Widget/Detail/ObjectDetail.php
@@ -21,6 +21,7 @@
 use Icinga\Module\Icingadb\Common\Macros;
 use Icinga\Module\Icingadb\Compat\CompatHost;
 use Icinga\Module\Icingadb\Model\CustomvarFlat;
+use Icinga\Module\Icingadb\Model\Service;
 use Icinga\Module\Icingadb\Model\UnreachableParent;
 use Icinga\Module\Icingadb\Web\Navigation\Action;
 use Icinga\Module\Icingadb\Widget\ItemList\DependencyNodeList;
@@ -606,7 +607,10 @@ protected function fetchCustomVars()
 
     protected function createRootProblems(): ?array
     {
-        if ($this->object->state->is_reachable) {
+        if (
+            $this->object->state->is_reachable
+            || ($this->object instanceof Service && ! $this->object->has_root_problem)
+        ) {
             return null;
         }