ui: Do not show okay states as handled if the object is unreachable

fixes #993
Icinga · Mar 22, 2024 · 91827cb · 91827cb
1 parent fbc3778
commit 91827cb
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 4 deletions.
diff --git a/library/Icingadb/Widget/ItemList/HostDetailHeader.php b/library/Icingadb/Widget/ItemList/HostDetailHeader.php
@@ -50,7 +50,9 @@ protected function assembleVisual(BaseHtmlElement $visual): void
         }
 
         $stateChange->setIcon($this->state->getIcon());
-        $stateChange->setHandled($this->state->is_handled || ! $this->state->is_reachable);
+        $stateChange->setHandled(
+            $this->state->is_problem && ($this->state->is_handled || ! $this->state->is_reachable)
+        );
 
         $visual->addHtml($stateChange);
     }

diff --git a/library/Icingadb/Widget/ItemList/ServiceDetailHeader.php b/library/Icingadb/Widget/ItemList/ServiceDetailHeader.php
@@ -50,7 +50,9 @@ protected function assembleVisual(BaseHtmlElement $visual): void
         }
 
         $stateChange->setIcon($this->state->getIcon());
-        $stateChange->setHandled($this->state->is_handled || ! $this->state->is_reachable);
+        $stateChange->setHandled(
+            $this->state->is_problem && ($this->state->is_handled || ! $this->state->is_reachable)
+        );
 
         $visual->addHtml($stateChange);
     }

diff --git a/library/Icingadb/Widget/ItemList/StateListItem.php b/library/Icingadb/Widget/ItemList/StateListItem.php
@@ -99,7 +99,7 @@ protected function assembleVisual(BaseHtmlElement $visual): void
     {
         $stateBall = new StateBall($this->state->getStateText(), $this->getStateBallSize());
         $stateBall->add($this->state->getIcon());
-        if ($this->state->is_handled || ! $this->state->is_reachable) {
+        if ($this->state->is_problem && ($this->state->is_handled || ! $this->state->is_reachable)) {
             $stateBall->getAttributes()->add('class', 'handled');
         }
 

diff --git a/library/Icingadb/Widget/ItemTable/StateRowItem.php b/library/Icingadb/Widget/ItemTable/StateRowItem.php
@@ -33,7 +33,7 @@ protected function assembleVisual(BaseHtmlElement $visual)
         $stateBall = new StateBall($this->item->state->getStateText(), StateBall::SIZE_LARGE);
         $stateBall->add($this->item->state->getIcon());
 
-        if ($this->item->state->is_handled) {
+        if ($this->item->state->is_problem && ($this->item->state->is_handled || ! $this->item->state->is_reachable)) {
             $stateBall->getAttributes()->add('class', 'handled');
         }
 

diff --git a/phpstan-baseline-standard.neon b/phpstan-baseline-standard.neon
@@ -7635,6 +7635,16 @@ parameters:
 			count: 1
 			path: library/Icingadb/Widget/ItemTable/StateRowItem.php
 
+		-
+			message: "#^Cannot access property \\$is_problem on mixed\\.$#"
+			count: 1
+			path: library/Icingadb/Widget/ItemTable/StateRowItem.php
+
+		-
+			message: "#^Cannot access property \\$is_reachable on mixed\\.$#"
+			count: 1
+			path: library/Icingadb/Widget/ItemTable/StateRowItem.php
+
 		-
 			message: "#^Cannot access property \\$last_state_change on mixed\\.$#"
 			count: 1