Don't pass an array to ObjectsCommand::setObjects()

fixes #832
Icinga · Aug 10, 2023 · 987a0a3 · 987a0a3
1 parent 17adfc2
commit 987a0a3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/application/controllers/HostController.php b/application/controllers/HostController.php
@@ -4,6 +4,7 @@
 
 namespace Icinga\Module\Icingadb\Controllers;
 
+use ArrayIterator;
 use Icinga\Exception\NotFoundError;
 use Icinga\Module\Icingadb\Command\Object\GetObjectCommand;
 use Icinga\Module\Icingadb\Command\Transport\CommandTransport;
@@ -86,7 +87,11 @@ public function indexAction()
     public function sourceAction()
     {
         $this->assertPermission('icingadb/object/show-source');
-        $apiResult = (new CommandTransport())->send((new GetObjectCommand())->setObjects([$this->host]));
+
+        $apiResult = (new CommandTransport())->send(
+            (new GetObjectCommand())
+                ->setObjects(new ArrayIterator([$this->host]))
+        );
 
         if ($this->host->state->is_overdue) {
             $this->controls->addAttributes(['class' => 'overdue']);

diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
@@ -4,6 +4,7 @@
 
 namespace Icinga\Module\Icingadb\Controllers;
 
+use ArrayIterator;
 use Icinga\Exception\NotFoundError;
 use Icinga\Module\Icingadb\Command\Object\GetObjectCommand;
 use Icinga\Module\Icingadb\Command\Transport\CommandTransport;
@@ -91,7 +92,11 @@ public function indexAction()
     public function sourceAction()
     {
         $this->assertPermission('icingadb/object/show-source');
-        $apiResult = (new CommandTransport())->send((new GetObjectCommand())->setObjects([$this->service]));
+
+        $apiResult = (new CommandTransport())->send(
+            (new GetObjectCommand())
+                ->setObjects(new ArrayIterator([$this->service]))
+        );
 
         if ($this->service->state->is_overdue) {
             $this->controls->addAttributes(['class' => 'overdue']);

diff --git a/library/Icingadb/Command/Object/ObjectsCommand.php b/library/Icingadb/Command/Object/ObjectsCommand.php
@@ -4,6 +4,7 @@
 
 namespace Icinga\Module\Icingadb\Command\Object;
 
+use ArrayIterator;
 use Icinga\Module\Icingadb\Command\IcingaCommand;
 use ipl\Orm\Model;
 use Traversable;
@@ -45,7 +46,7 @@ public function setObjects(Traversable $objects): self
      */
     public function setObject(Model $object): self
     {
-        return $this->setObjects([$object]);
+        return $this->setObjects(new ArrayIterator([$object]));
     }
 
     /**